Skip to content

Conversation

@grokspawn
Copy link
Contributor

Adding me to list of approvers

Signed-off-by: grokspawn jordan@nimblewidget.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from ecordell and jmrodri July 26, 2022 22:07
Adding me to list of approvers

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the grokspawn-approver branch from 782ffeb to 252cd6e Compare July 26, 2022 22:12
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #996 (252cd6e) into master (2a21178) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files         104      104           
  Lines        9468     9468           
=======================================
  Hits         5007     5007           
  Misses       3528     3528           
  Partials      933      933           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a21178...252cd6e. Read the comment docs.

@perdasilva
Copy link
Contributor

/approve

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@timflannagan
Copy link
Member

/lgtm

@perdasilva
Copy link
Contributor

/approve

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, grokspawn, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit eb2e639 into master Jul 28, 2022
@grokspawn grokspawn deleted the grokspawn-approver branch August 19, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants