Skip to content

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Jun 9, 2020

Adds a releases tab which points to versioned documentation. These changes should be cherry picked back to all live versions of the docs (0.17.x, 0.18.x)

@asmacdo
Copy link
Member Author

asmacdo commented Jun 9, 2020

Link check failure expected until #3201 is merged.

@asmacdo asmacdo force-pushed the versioned-doc-links branch from bd17a8b to 710539b Compare June 9, 2020 13:20
Copy link
Contributor

@matthewcarleton matthewcarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing other than my inline comment.
Having the "release" text white would be better for contrast.
Other than that - LGTM!

@asmacdo asmacdo force-pushed the versioned-doc-links branch from 710539b to 6c10bd5 Compare June 9, 2020 13:42
* Also needed to add releases back to navbar in the layouts.
@asmacdo asmacdo force-pushed the versioned-doc-links branch from 6c10bd5 to 910faf4 Compare June 9, 2020 14:23
@asmacdo asmacdo closed this Jun 9, 2020
@asmacdo asmacdo reopened this Jun 9, 2020
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@asmacdo asmacdo merged commit 2041129 into operator-framework:master Jun 9, 2020
@asmacdo
Copy link
Member Author

asmacdo commented Jun 10, 2020

/cherrypick v0.18.x

@openshift-cherrypick-robot

@asmacdo: new pull request created: #3217

In response to this:

/cherrypick v0.18.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants