Add Lumen v9+ compatibility

[kargnas]

Summary

• allow installing the package alongside Lumen 9.x and 10.x by widening the illuminate and lumen framework constraints
• tweak the service provider to use the container binding API so Lumen apps without global helpers still register cleanly
• document the broader Lumen support window and guard the Lumen-specific tests when the framework isn't present

Testing

• composer test

---

https://chatgpt.com/codex/tasks/task_e_68eabed37440832195c976af7fe71767

[claude]

Code Review - PR #83: Add Lumen v9+ compatibility

✅ Overall Assessment

This is a well-crafted PR that successfully extends Lumen compatibility from v11+ to v9+. The changes are minimal, focused, and follow Laravel/Lumen best practices.

---

🎯 Code Quality & Best Practices

Strengths:

• Excellent API usage improvement: Changing from app()->has() to $this->app->bound() (line 79 in LaravelMcpServerServiceProvider.php) is the correct approach. The bound() method is the standard Laravel container API, while has() is a helper that may not exist in all contexts, especially in Lumen applications without global helpers.
• Consistent with existing code: The change aligns with line 166 where bound() is already used for the config service.
• Proper test guard: Adding the class_exists() check in TestCase.php:19-21 ensures tests are skipped gracefully when Lumen isn't installed, which is essential for a package that supports both Laravel and Lumen.
• Clear documentation: README updates accurately reflect the new compatibility range.

Minor Observations:

• The composer.json constraints are properly versioned using semantic versioning syntax (^9.0||^10.0||^11.0)

---

🐛 Potential Bugs or Issues

No critical issues found. However, some considerations:

1. Illuminate/contracts v9.0 compatibility:

   • Lumen 9.x uses illuminate/contracts ^9.0, which was released in early 2022
   • The package already uses standard container methods (bound(), array access) that have been stable since Laravel 5.x
   • ✅ The change from app()->has() to $this->app->bound() actually prevents potential issues in Lumen environments

2. Service provider compatibility:

   • The PackageServiceProvider base class from Spatie's package-tools should be compatible with illuminate/contracts v9.0
   • ✅ No deprecated method calls detected in the service provider

3. Test skipping logic:

   • The test skip happens in setUp(), which is appropriate
   • ✅ Prevents test initialization errors when Lumen isn't available

---

⚡ Performance Considerations

No performance concerns:

• The bound() method is actually slightly more direct than app()->has() since it doesn't require helper function resolution
• The class_exists() check in tests has negligible overhead and only runs once per test class
• No additional dependencies or heavy operations introduced

---

🔒 Security Concerns

No security issues identified:

• No changes to authentication, authorization, or data handling
• No new external dependencies
• No changes to route registration logic or middleware handling
• The widened version constraints don't introduce security risks (Lumen 9+ and Laravel 10+ are all maintained versions)

---

🧪 Test Coverage

Good test coverage approach:

Existing tests:

• ✅ Lumen-specific tests in tests/Lumen/LumenRouteRegistrationTest.php will now run against Lumen 9.x-11.x
• ✅ Test skip guard prevents failures in environments without Lumen
• ✅ Tests cover route registration for both SSE and streamable_http providers

Recommendations:

1. Consider running CI tests with a Lumen 9.x matrix to verify compatibility (optional but recommended)
2. The existing test suite should be sufficient - no new tests strictly required for this change

Test commands from CLAUDE.md:

vendor/bin/pest                    # Run all tests
vendor/bin/pest --coverage         # With coverage
vendor/bin/phpstan analyse         # Static analysis

---

📋 Suggestions

Optional improvements (not blocking):

1. Add version testing to CI (optional):
   Consider adding a test matrix entry for Lumen 9.x/10.x in .github/workflows/tests.yml to ensure ongoing compatibility:

   matrix:
     include:
       - php: 8.2
         lumen: ^9.0
       - php: 8.3
         lumen: ^10.0

2. Changelog entry (recommended):
   Add an entry to CHANGELOG.md documenting this backward compatibility extension.

---

✅ Approval Recommendation

This PR is ready to merge.

The changes are:

• ✅ Well-tested (existing test suite covers the changes)
• ✅ Following best practices (using container API correctly)
• ✅ Backward compatible (only extends support, doesn't break existing usage)
• ✅ Properly documented (README updated)
• ✅ Security-neutral (no security implications)
• ✅ Performance-neutral (no performance impact)

The fix to use $this->app->bound() instead of app()->has() is actually an improvement that makes the code more robust in Lumen environments where global helpers might not be enabled.

---

Great work on this PR! The implementation is clean and minimal, which is exactly what's needed for a compatibility extension.

🤖 Generated with Claude Code