Skip to content

Commit dabc3cf

Browse files
committed
vlan: do not protect PCP write with the sysctl
pf will unconditionally "set prio", so this will fail if the sysctl is off. The sysctl, however, introduces a side-effect so we would rather keep the default behaviour. The allocation slowdown is already taking place, so this in the worst case only adds a list traversal / lookup. PR: https://forum.opnsense.org/index.php?topic=6714.0
1 parent 5c70e2a commit dabc3cf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sys/net/if_vlan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1102,7 +1102,7 @@ vlan_transmit(struct ifnet *ifp, struct mbuf *m)
11021102
* knows how to find the VLAN tag to use, so we attach a
11031103
* packet tag that holds it.
11041104
*/
1105-
if (vlan_mtag_pcp && (mtag = m_tag_locate(m, MTAG_8021Q,
1105+
if ((mtag = m_tag_locate(m, MTAG_8021Q,
11061106
MTAG_8021Q_PCP_OUT, NULL)) != NULL)
11071107
tag = EVL_MAKETAG(ifv->ifv_vid, *(uint8_t *)(mtag + 1), 0);
11081108
else

0 commit comments

Comments
 (0)