Skip to content

Commit ddb08b1

Browse files
committed
pf: if we have a state, why not use it?
PR: opnsense/core#2376
1 parent 6f9578a commit ddb08b1

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

sys/netpfil/pf/pf.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5674,8 +5674,7 @@ pf_route_shared(struct mbuf **m, struct pf_rule *r, int dir, struct ifnet *ifp,
56745674
&naddr, NULL, &sn);
56755675
if (!PF_AZERO(&naddr, AF_INET))
56765676
dst.sin_addr.s_addr = naddr.v4.s_addr;
5677-
ifp = r->rpool.cur->kif ?
5678-
r->rpool.cur->kif->pfik_ifp : NULL;
5677+
ifp = sn && sn->kif ? sn->kif->pfik_ifp : NULL;
56795678
} else {
56805679
if (!PF_AZERO(&s->rt_addr, AF_INET))
56815680
dst.sin_addr.s_addr =
@@ -5913,7 +5912,7 @@ pf_route6_shared(struct mbuf **m, struct pf_rule *r, int dir,
59135912
if (!PF_AZERO(&naddr, AF_INET6))
59145913
PF_ACPY((struct pf_addr *)&dst.sin6_addr,
59155914
&naddr, AF_INET6);
5916-
ifp = r->rpool.cur->kif ? r->rpool.cur->kif->pfik_ifp : NULL;
5915+
ifp = sn && sn->kif ? sn->kif->pfik_ifp : NULL;
59175916
} else {
59185917
if (!PF_AZERO(&s->rt_addr, AF_INET6))
59195918
PF_ACPY((struct pf_addr *)&dst.sin6_addr,

0 commit comments

Comments
 (0)