Remove task_report.py #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #143 +/- ##
===========================================
+ Coverage 69.43% 70.25% +0.81%
===========================================
Files 83 82 -1
Lines 7548 7460 -88
Branches 1394 1384 -10
===========================================
Hits 5241 5241
+ Misses 1932 1844 -88
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
We'd have to create a pipeline for the Infrahub project where we updated the submodule commit to use this branch and verify that it works within Infrahub itself first. I think we're still using this task_report object in a number of places there. |
|
There's a merge conflict on this PR, but I think we should be able completely remove the task_report from here now? |
# Conflicts: # infrahub_sdk/task_report.py
LucasG0
force-pushed
the
lgu-remove-task-report
branch
from
ec1d107 to
6c6bd0a
Compare
ogenstad
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to IFC-917