Prep for 1.3 and add release note #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #186 +/- ##
========================================
Coverage 65.43% 65.43%
========================================
Files 81 81
Lines 7259 7259
Branches 1409 1409
========================================
Hits 4750 4750
Misses 2122 2122
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. |
dgarros
force-pushed
the
dga-20241230-rn-1.3
branch
from
ab3f882 to
97388b6
Compare
ogenstad
reviewed
Dec 30, 2024
|
|
||
| ### Changed | ||
|
|
||
| - The Pydantic models for the schema have been split into multiple versions to align better with the different phase of the lifecycle of the schema. |
Contributor
There was a problem hiding this comment.
Should we highlight this a bit more to indicate that if people were importing the repository classes from infrahub_sdk.schema they would need to change those imports? While I don't see why end users would have to import these classes you never know.
Contributor
Author
There was a problem hiding this comment.
I'm planning to send a quick note in Discord as well ... as you mentioned I don't think a lot of users are using these models today
also, the import should still work ... the main difference is that some attributes have been removed from the models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.