Skip to content

Conversation

@FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Jan 18, 2025

These changes allow us to set the ref which is used to define what release/branch/commit to uae

  • Do not create/set blank credentials if no username or password are provided
  • Change commit to ref option and update code to reflect the same (Breaking Change)

Is commit supposed to be an available field to update or one that gets set on synchronization?

…tion in favor of ref option to match API and allow setting the ref on CTL.
@codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##           stable     #244      +/-   ##
==========================================
+ Coverage   70.35%   70.36%   +0.01%     
==========================================
  Files          82       82              
  Lines        7498     7502       +4     
  Branches     1389     1391       +2     
==========================================
+ Hits         5275     5279       +4     
  Misses       1849     1849              
  Partials      374      374              
Flag Coverage Δ
integration-tests 22.44% <0.00%> (-0.02%) ⬇️
python-3.10 45.58% <100.00%> (+0.02%) ⬆️
python-3.11 45.58% <100.00%> (+0.02%) ⬆️
python-3.12 45.58% <100.00%> (+0.02%) ⬆️
python-3.13 45.58% <100.00%> (+0.02%) ⬆️
python-3.9 45.58% <100.00%> (+0.02%) ⬆️
python-filler-3.12 23.95% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/repository.py 81.57% <100.00%> (+1.02%) ⬆️

@BaptisteGi BaptisteGi requested a review from a team February 7, 2025 14:11
Copy link
Contributor

@BaptisteGi BaptisteGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict to resolve otherwise sounds good!

@FragmentedPacket FragmentedPacket merged commit 81c7493 into stable Feb 11, 2025
15 checks passed
@FragmentedPacket FragmentedPacket deleted the may-202501-repo-ref-commit-fix-1 branch February 11, 2025 19:21
dgarros pushed a commit that referenced this pull request Feb 23, 2025
* Refactor repository to not create blank credentials. Remove commit option in favor of ref option to match API and allow setting the ref on CTL.

* Format/Lint.

* Fixed payload between CoreRepositoryCreate and CoreReadOnlyRepositoryCreate mutations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants