Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Jan 24, 2025

Fixes #206

@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/config.py 0.00% 0 Missing and 1 partial ⚠️
infrahub_sdk/ctl/check.py 0.00% 1 Missing ⚠️
infrahub_sdk/data.py 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##           develop     #249   +/-   ##
========================================
  Coverage    70.39%   70.39%           
========================================
  Files           82       82           
  Lines         7482     7482           
  Branches      1387     1387           
========================================
  Hits          5267     5267           
  Misses        1841     1841           
  Partials       374      374           
Flag Coverage Δ
integration-tests 22.40% <0.00%> (ø)
python-3.10 45.65% <62.50%> (ø)
python-3.11 45.65% <62.50%> (ø)
python-3.12 45.65% <62.50%> (ø)
python-3.13 45.65% <62.50%> (ø)
python-3.9 45.65% <62.50%> (ø)
python-filler-3.12 24.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/batch.py 94.52% <100.00%> (ø)
infrahub_sdk/ctl/utils.py 66.42% <100.00%> (ø)
infrahub_sdk/node.py 77.58% <ø> (ø)
infrahub_sdk/protocols.py 100.00% <ø> (ø)
infrahub_sdk/schema/__init__.py 68.01% <ø> (ø)
infrahub_sdk/transfer/exporter/json.py 19.79% <100.00%> (ø)
infrahub_sdk/config.py 87.25% <0.00%> (ø)
infrahub_sdk/ctl/check.py 27.04% <0.00%> (ø)
infrahub_sdk/data.py 73.33% <0.00%> (ø)

@dgarros dgarros requested a review from a team January 24, 2025 17:26
@dgarros dgarros marked this pull request as ready for review January 24, 2025 17:27
@dgarros dgarros merged commit d002b85 into develop Jan 27, 2025
14 checks passed
@dgarros dgarros deleted the dga-fix-206 branch January 27, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants