Skip to content

Conversation

@wartraxx51
Copy link
Contributor

No description provided.

@github-actions github-actions bot added group/ci Issue related to the CI pipeline type/documentation Improvements or additions to documentation labels Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           stable     #262   +/-   ##
=======================================
  Coverage   70.32%   70.32%           
=======================================
  Files          81       81           
  Lines        7507     7507           
  Branches     1464     1464           
=======================================
  Hits         5279     5279           
+ Misses       1848     1846    -2     
- Partials      380      382    +2     
Flag Coverage Δ
integration-tests 22.43% <ø> (ø)
python-3.10 45.49% <ø> (ø)
python-3.11 45.49% <ø> (ø)
python-3.12 45.49% <ø> (ø)
python-3.9 44.31% <ø> (ø)
python-filler-3.12 23.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch from 132aac1 to c991e5b Compare February 4, 2025 21:49
@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch 2 times, most recently from bc40428 to ee27da6 Compare February 19, 2025 00:46
@dgarros
Copy link
Contributor

dgarros commented Feb 19, 2025

I think we also need to migrate the folder infrahubctl https://github.com/opsmill/infrahub/tree/stable/docs/docs/infrahubctl and the associated command to generate the documentation for it automatically

@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch 3 times, most recently from 5e02747 to e2a8b30 Compare February 19, 2025 22:37
@petercrocker petercrocker requested a review from a team February 21, 2025 11:31
@petercrocker petercrocker marked this pull request as draft February 21, 2025 11:50
@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch 2 times, most recently from d591234 to 7868fd7 Compare February 24, 2025 12:55
@wartraxx51 wartraxx51 marked this pull request as ready for review February 24, 2025 13:20
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch from 0a5ccf2 to e08ce10 Compare February 24, 2025 19:10
Copy link
Contributor

@petercrocker petercrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally, reviewed. all good! 🙌🏼

@wartraxx51 wartraxx51 force-pushed the jbr-migration-doc-sdk branch from e08ce10 to 97cd124 Compare February 26, 2025 08:37
@wartraxx51 wartraxx51 merged commit 50c01e2 into stable Feb 26, 2025
18 checks passed
@wartraxx51 wartraxx51 deleted the jbr-migration-doc-sdk branch February 26, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline type/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants