Skip to content

Conversation

@wvandeun
Copy link
Contributor

@wvandeun wvandeun commented Feb 10, 2025

Now that artifacts are properly getting their name from the artifact_name attribute of the artifact definition (opsmill/infrahub#5484), we need to update the InfrahubNode artifact_fetch and artifact_generate method to use the name of the artifact instead.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           stable     #266   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          82       82           
  Lines        7497     7497           
  Branches     1389     1389           
=======================================
  Hits         5275     5275           
  Misses       1848     1848           
  Partials      374      374           
Flag Coverage Δ
integration-tests 22.46% <0.00%> (ø)
python-3.10 45.56% <100.00%> (ø)
python-3.11 45.56% <100.00%> (ø)
python-3.12 45.56% <100.00%> (ø)
python-3.13 45.56% <100.00%> (ø)
python-3.9 45.56% <100.00%> (ø)
python-filler-3.12 23.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node.py 77.58% <100.00%> (ø)

@wvandeun wvandeun self-assigned this Feb 10, 2025
@wvandeun wvandeun marked this pull request as ready for review February 10, 2025 15:40
@wvandeun wvandeun merged commit 0d491c0 into stable Feb 11, 2025
15 checks passed
@wvandeun wvandeun deleted the wvd-20250210-fix-node-artifact-methods branch February 11, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants