Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Feb 21, 2025

Fixes #190

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 72.58065% with 68 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/task/manager.py 60.00% 56 Missing and 10 partials ⚠️
infrahub_sdk/task/exceptions.py 88.23% 2 Missing ⚠️
@@                 Coverage Diff                  @@
##           infrahub-develop     #276      +/-   ##
====================================================
+ Coverage             69.59%   70.41%   +0.81%     
====================================================
  Files                    81       85       +4     
  Lines                  7719     7753      +34     
  Branches               1536     1506      -30     
====================================================
+ Hits                   5372     5459      +87     
+ Misses                 1954     1903      -51     
+ Partials                393      391       -2     
Flag Coverage Δ
integration-tests 21.77% <1.61%> (-0.48%) ⬇️
python-3.10 45.10% <33.06%> (-0.42%) ⬇️
python-3.11 45.10% <33.06%> (-0.40%) ⬇️
python-3.12 45.10% <33.06%> (-0.40%) ⬇️
python-3.9 43.96% <33.06%> (-0.39%) ⬇️
python-filler-3.12 24.51% <40.32%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 67.38% <100.00%> (+0.29%) ⬆️
infrahub_sdk/task/constants.py 100.00% <100.00%> (ø)
infrahub_sdk/task/models.py 100.00% <100.00%> (ø)
infrahub_sdk/task/exceptions.py 88.23% <88.23%> (ø)
infrahub_sdk/task/manager.py 60.00% <60.00%> (ø)

... and 2 files with indirect coverage changes

@dgarros dgarros changed the base branch from stable to develop February 22, 2025 14:17
@dgarros dgarros marked this pull request as ready for review February 26, 2025 14:49
@dgarros dgarros changed the base branch from develop to infrahub-develop February 26, 2025 14:49
@dgarros dgarros requested a review from a team February 26, 2025 18:20
progress: float | None = None
workflow: str | None = None
branch: str | None = None
# start_time: datetime # Is it still required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is not required, it seems.

@dgarros dgarros merged commit 4de1ddf into infrahub-develop Mar 1, 2025
13 checks passed
@dgarros dgarros deleted the dga-20250220-tasks branch March 1, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add support for Tasks

4 participants