Add integration tests for Task and add support for Enum #299
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## infrahub-develop #299 +/- ##
====================================================
+ Coverage 70.62% 71.04% +0.41%
====================================================
Files 85 86 +1
Lines 7824 7849 +25
Branches 1513 1520 +7
====================================================
+ Hits 5526 5576 +50
+ Misses 1908 1881 -27
- Partials 390 392 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I think we'll need to take a closer look at enums in general as there are different variations. We have our own Enums (which doesn't yet behave as GraphQL enums) within the schema that are different than GraphQL enums. I'm not sure this comes across anywhere. Than I think there might be more to be done with regards to the generation of Python protocols when it comes to enums.
|
|
||
|
|
||
| def convert_to_graphql_as_string(value: str | bool | list) -> str: | ||
| def convert_to_graphql_as_string(value: str | bool | list | BaseModel | Enum | Any, convert_enum: bool = False) -> str: # noqa: PLR0911 |
There was a problem hiding this comment.
In some other places for PLR0911 we've assigned the return value within multiple if-statements / match cases like this to avoid having a high number of returns.
2 participants
Fix #18
This PR adds some integration tests for Task and fixes various issues related to task
In order to fully support task, this PR also adds the support for Enum to GraphQL query and mutation (#18)
By default, an enum will be rendered as an Enum but it's also possible to convert Enum to their respective value.