Skip to content

Conversation

@wvandeun
Copy link
Contributor

@wvandeun wvandeun commented Mar 13, 2025

Stores CoreStandardGroups that are created or updated by a generator as members of the CoreGeneratorGroup.
Previously they were stored as children of the CoreGeneratorGroup, which created a weird behavior, especially in the UI where groups are shown hierarchically.

@wvandeun wvandeun self-assigned this Mar 13, 2025
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/query_groups.py 0.00% 6 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    70.38%   70.58%   +0.20%     
===========================================
  Files           81       81              
  Lines         7522     7499      -23     
  Branches      1467     1457      -10     
===========================================
- Hits          5294     5293       -1     
+ Misses        1844     1822      -22     
  Partials       384      384              
Flag Coverage Δ
integration-tests 22.60% <0.00%> (+0.05%) ⬆️
python-3.10 45.56% <0.00%> (+0.12%) ⬆️
python-3.11 45.56% <0.00%> (+0.12%) ⬆️
python-3.12 45.56% <0.00%> (?)
python-3.9 44.40% <0.00%> (+0.12%) ⬆️
python-filler-3.12 24.05% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/query_groups.py 46.87% <0.00%> (+6.47%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wvandeun wvandeun changed the title Store group as members of generator group Store groups as members of generator group Mar 13, 2025
@wvandeun wvandeun force-pushed the wvd-20250313-store-group-as-members-of-generator-group branch from a5b97a6 to 3d3aed8 Compare March 13, 2025 10:05
@wvandeun wvandeun marked this pull request as ready for review March 13, 2025 10:05
@wvandeun wvandeun merged commit f55276c into develop Mar 13, 2025
16 checks passed
@wvandeun wvandeun deleted the wvd-20250313-store-group-as-members-of-generator-group branch March 13, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants