Add parameter to only optionally refresh the schema hash on schema.all #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is primarily for use within computed attributes, currently for the Jinja2 template based computed attributes we are constantly refreshing the schema of the SDK for each attribute. This is because we have no way of knowing if the schema in the client is up to date or if a branch we'd previously cashed has updates. With this in place we can send in the current hash stored in the registry to the schema.all method and only call the
/api/schemaendpoint if any updates have actually been made.As a follow up to this PR I'm thinking that we should mark the public schema.fetch() method as deprecated. I don't think anyone uses it and instead use schema.get() or schema.all().
Fixes #152.