Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Apr 14, 2025

Fixes #286

I want this in place for better error messages for computed attributes when we've deleted branches. I think it mostly shows up in the e2e tests within the pipelines. But should be cleaned up.

Also takes care of a variation where the internal workings of the sync and async client differed.

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema/__init__.py 83.33% 2 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    72.45%   73.06%   +0.60%     
===========================================
  Files           91       92       +1     
  Lines         8180     8205      +25     
  Branches      1576     1585       +9     
===========================================
+ Hits          5927     5995      +68     
+ Misses        1841     1799      -42     
+ Partials       412      411       -1     
Flag Coverage Δ
integration-tests 22.31% <58.33%> (-0.02%) ⬇️
python-3.10 47.21% <50.00%> (+0.67%) ⬆️
python-3.11 47.21% <50.00%> (+0.69%) ⬆️
python-3.12 47.19% <50.00%> (+0.65%) ⬆️
python-3.13 47.19% <50.00%> (+0.65%) ⬆️
python-3.9 45.54% <50.00%> (+0.65%) ⬆️
python-filler-3.12 25.04% <16.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema/__init__.py 71.20% <83.33%> (+1.39%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad requested a review from a team April 14, 2025 12:30
@ogenstad ogenstad merged commit aeb62d1 into develop Apr 15, 2025
18 checks passed
@ogenstad ogenstad deleted the pog-schema-branch-not-found-error-IHS-109 branch April 15, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants