-
Couldn't load subscription status.
- Fork 6
fixed broken link #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed broken link #474
Conversation
WalkthroughA documentation file was updated to change a hyperlink target in Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to documentation hyperlink updates. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
ef1da98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67cd41a4.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://doc-broken-link.infrahub-sdk-python.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/docs/python-sdk/guides/resource-manager.mdx (1)
183-183: Prefer a relative link over a hard-coded GitHub URLHard-coding the full GitHub path ties the docs to one repo location and breaks in offline or versioned site builds. A relative link keeps everything within the Docusaurus routing and is easier to maintain.
-[generators](https://github.com/opsmill/infrahub-docs/blob/main/docs/docs/topics/generator.mdx) +[generators](/docs/topics/generator)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docs/python-sdk/guides/resource-manager.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
docs/docs/python-sdk/guides/resource-manager.mdx (1)
183-183: Fixed broken link – looks goodAdding the
.mdxextension removes the 404 and restores navigation. Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vsurresh
I think the link should be https://docs.infrahub.app/topics/generator instead
Not sure why we are pointing at the Github repository but this looks wrong to me.
The 'generators' link is missing the extension, so clicking the link from the doc results in a broken page. Quick fix.
Summary by CodeRabbit