-
Notifications
You must be signed in to change notification settings - Fork 6
Merge stable into develop #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ort-to-protocols add support for NumerPool attributes to protocols
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
| Latest commit: |
5daba0e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ca83bda.infrahub-sdk-python.pages.dev |
This change moves the `get_flat_value` function to methods of the `InfrahubNode` and `InfrahubNodeSync` classes. This allows to handle traversing relationships of cardinality one using a flat notation in addition to attributes. The `extract` method has also been moved as it needs to be async for regular nodes now.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## develop #486 +/- ##
===========================================
+ Coverage 75.76% 75.83% +0.07%
===========================================
Files 100 100
Lines 8838 8870 +32
Branches 1733 1740 +7
===========================================
+ Hits 6696 6727 +31
- Misses 1666 1667 +1
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Merging stable into develop after merging pull request #484.