Skip to content

Conversation

@petercrocker
Copy link
Contributor

@petercrocker petercrocker commented Oct 7, 2025

Updated docusaurus to v3.9.1 to fix two dependabot issues:

Summary by CodeRabbit

  • Documentation
    • Adjusted documentation site configuration so broken Markdown links are handled via markdown-specific settings; behavior remains the same and warnings are still produced.
  • Chores
    • Added a project Node version specification (Node 20) to help standardize development environments.

@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Oct 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025

Walkthrough

Moved the Docusaurus onBrokenMarkdownLinks setting from the top-level config into markdown.hooks.onBrokenMarkdownLinks with the same value 'warn', changing only the configuration nesting. Added a new .nvmrc file containing 20 (specifying Node.js v20). No exported or public declarations were modified.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “update docusaurus” concisely conveys that the pull request’s primary change is upgrading the Docusaurus setup to a newer version. It specifically names the component being updated without extraneous detail and aligns with the adjustments in configuration nesting. This clear reference ensures teammates scanning the commit history immediately understand the PR’s intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pmc-20251007-docusaurus

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50db5d3 and 8867058.

📒 Files selected for processing (1)
  • .nvmrc (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .nvmrc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@petercrocker petercrocker requested a review from a team October 7, 2025 08:42
Docusaurus 3.9.1 requires Node.js >= 20.0, but Cloudflare Pages was using v18.17.1, causing build failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8867058
Status: ✅  Deploy successful!
Preview URL: https://da5ec3c6.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pmc-20251007-docusaurus.infrahub-sdk-python.pages.dev

View logs

@dgarros dgarros merged commit 66395d4 into stable Oct 11, 2025
14 checks passed
@dgarros dgarros deleted the pmc-20251007-docusaurus branch October 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants