Skip to content

Conversation

@infrahub-github-bot-app
Copy link
Contributor

Merging develop into infrahub-develop after merging pull request #586.

* IHS-128: Replace `Sync` in protocol sync classes schema name

Fixes #380

This PR replaces the `Sync` word in the protocol schema name so that the correct kind can be gotten from the cache.

* add towncrier

* refactor get_schema_name, add test

* update test
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fb0758
Status: ✅  Deploy successful!
Preview URL: https://f94913cd.infrahub-sdk-python.pages.dev
Branch Preview URL: https://develop.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema/__init__.py 71.42% 0 Missing and 2 partials ⚠️
@@                 Coverage Diff                  @@
##           infrahub-develop     #587      +/-   ##
====================================================
+ Coverage             75.68%   76.05%   +0.37%     
====================================================
  Files                   108      108              
  Lines                 10276    10604     +328     
  Branches               2130     2242     +112     
====================================================
+ Hits                   7777     8065     +288     
- Misses                 1944     1964      +20     
- Partials                555      575      +20     
Flag Coverage Δ
integration-tests 36.01% <28.57%> (+0.08%) ⬆️
python-3.10 50.33% <57.14%> (+0.36%) ⬆️
python-3.11 50.31% <57.14%> (+0.35%) ⬆️
python-3.12 50.31% <57.14%> (+0.36%) ⬆️
python-3.13 50.29% <57.14%> (+0.35%) ⬆️
python-3.9 48.82% <57.14%> (+0.37%) ⬆️
python-filler-3.12 24.12% <14.28%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema/__init__.py 72.70% <71.42%> (+6.34%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad merged commit c50ee21 into infrahub-develop Oct 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants