Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Nov 10, 2025

Ignores warnings in the VS Code extension for Vale with regards to unrelated files such as *.toml.

Screenshot 2025-11-10 at 16 36 49

Summary by CodeRabbit

  • Chores
    • Updated configuration to exclude TOML files from style validation checks.

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Walkthrough

The .vale.ini configuration file is updated to add a new [*.toml] section that disables all formatting and style rules for TOML files by setting BasedOnStyles to an empty value. The existing [*] section with BasedOnStyles set to Infrahub is retained. Comments are added to explain the configuration changes. This modification results in TOML files such as pyproject.toml being ignored by Vale during style checks.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: configuring Vale to ignore TOML files through .vale.ini configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pog-vale-ignore-toml

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88c7907 and 3ff56e8.

📒 Files selected for processing (1)
  • .vale.ini (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: opsmill/infrahub-sdk-python PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-24T13:35:12.998Z
Learning: Applies to docs/**/*.{md,mdx} : Conform to markdown style rules in .markdownlint.yaml and Vale styles in .vale/styles/
📚 Learning: 2025-08-24T13:35:12.998Z
Learnt from: CR
Repo: opsmill/infrahub-sdk-python PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-24T13:35:12.998Z
Learning: Applies to docs/**/*.{md,mdx} : Conform to markdown style rules in .markdownlint.yaml and Vale styles in .vale/styles/

Applied to files:

  • .vale.ini
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
.vale.ini (1)

14-17: Solid configuration to disable Vale rules for TOML files.

The new [*.toml] section correctly disables all formatting and style rules for TOML files by setting BasedOnStyles to an empty value. The comments clearly explain the purpose and provide a concrete example (pyproject.toml). This should successfully prevent false positives while maintaining Infrahub style rules for markdown documentation and other supported file types.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ff56e8
Status: ✅  Deploy successful!
Preview URL: https://0030e839.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-vale-ignore-toml.infrahub-sdk-python.pages.dev

View logs

@ogenstad ogenstad requested a review from a team November 10, 2025 15:37
@ogenstad ogenstad marked this pull request as ready for review November 10, 2025 15:44
@ogenstad ogenstad merged commit d9ead2d into stable Nov 11, 2025
14 checks passed
@ogenstad ogenstad deleted the pog-vale-ignore-toml branch November 11, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants