Skip to content

Conversation

@fatih-acar
Copy link
Contributor

@fatih-acar fatih-acar commented Nov 18, 2025

Summary by CodeRabbit

  • Chores
    • Streamlined PyPI publishing workflow for improved efficiency.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Nov 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

Walkthrough

The GitHub Actions workflow for publishing to PyPI was refactored by removing an intermediate token configuration step. The PyPI authentication token is now provided directly to the Publish to PyPI step through the UV_PUBLISH_TOKEN environment variable, which is set from the PyPI secret. The overall build and publish functionality remains unchanged; only the workflow structure was simplified by consolidating token handling into a single step.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(ci): uv publish command' is vague and doesn't clearly convey the specific change made to the PyPI publishing workflow. Provide a more descriptive title that clarifies the specific fix, such as 'fix(ci): simplify PyPI token configuration in publish workflow' or 'fix(ci): move PyPI token to environment variable in publish step'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fac-fix-pypi-publish

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc79402 and 6dcbe2c.

📒 Files selected for processing (1)
  • .github/workflows/publish-pypi.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
.github/workflows/publish-pypi.yml (1)

73-74: UV_PUBLISH_TOKEN is correctly configured for uv publish authentication.

The correct environment variable for uv publish API token authentication is UV_PUBLISH_TOKEN, which matches your implementation. The refactoring is sound and follows the official approach.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6dcbe2c
Status: ✅  Deploy successful!
Preview URL: https://95f28ad8.infrahub-sdk-python.pages.dev
Branch Preview URL: https://fac-fix-pypi-publish.infrahub-sdk-python.pages.dev

View logs

@fatih-acar fatih-acar merged commit d2b5c42 into develop Nov 18, 2025
14 checks passed
@fatih-acar fatih-acar deleted the fac-fix-pypi-publish branch November 18, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants