Skip to content

Conversation

@gmazoyer
Copy link
Contributor

When loading a new schema, generating relationships for templates could end up in trying to duplicate them which was leading to a schema load error (to avoid duplication). This change ensures that relationships that need update are removed fromt the template schema before re-adding them.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Feb 24, 2025
@gmazoyer gmazoyer marked this pull request as ready for review February 24, 2025 12:17
@gmazoyer gmazoyer requested a review from a team as a code owner February 24, 2025 12:17
@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch from f1a4f86 to f50b3ba Compare February 24, 2025 13:43
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #5832 will not alter performance

Comparing gma-20250224-templateduplicatrel (1d94e3f) with release-1.2 (afc93fc)

Summary

✅ 10 untouched benchmarks

@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch 2 times, most recently from 414a909 to 24330bb Compare February 24, 2025 14:53
@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch from b6c3ac9 to 3c3b3d8 Compare February 24, 2025 23:15
@dgarros
Copy link
Collaborator

dgarros commented Feb 25, 2025

When loading a new schema, generating relationships for templates could end up in trying to duplicate them which was leading to a schema load error (to avoid duplication). This change ensures that relationships that need update are removed fromt the template schema before re-adding them.

Are we storing the schema for these relationships in the database right now ? if the relationships are auto-generated I think it's best to not store the schema in the database altogether
it sounds similar to an issue @ajtmccarty is working on

@dgarros dgarros changed the base branch from release/1.2 to release-1.2 February 25, 2025 07:32
@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch from 3c3b3d8 to 98ab709 Compare February 25, 2025 09:40
@gmazoyer
Copy link
Contributor Author

Are we storing the schema for these relationships in the database right now ? if the relationships are auto-generated I think it's best to not store the schema in the database altogether it sounds similar to an issue @ajtmccarty is working on

Unless I'm mistaken none of this is stored in the database.

@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch 2 times, most recently from 376930c to f511ccb Compare February 25, 2025 14:01
Base automatically changed from release-1.2 to develop February 25, 2025 14:05
@gmazoyer gmazoyer changed the base branch from develop to release-1.2 February 25, 2025 15:01
@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch from f511ccb to 60aa293 Compare February 25, 2025 16:55
Only keep relationships of kind template as they are special.
@gmazoyer gmazoyer force-pushed the gma-20250224-templateduplicatrel branch from 60aa293 to 1d94e3f Compare February 25, 2025 20:06
@gmazoyer gmazoyer merged commit 6b333ec into release-1.2 Feb 25, 2025
34 of 35 checks passed
@gmazoyer gmazoyer deleted the gma-20250224-templateduplicatrel branch February 25, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants