apt has trouble with version starting with v #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new versioning convention introduces git tags that start with v this change will ensure that the leading v will be excluded when packages are being created. eg. GIT_TAG = TRAVIS_TAG = v0.2.0 then VERSION = 0.2.0 = DOCKER_TAG and versioning in rpm/deb packages
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
======================================
Coverage 65.8% 65.8%
======================================
Files 12 12
Lines 348 348
======================================
Hits 229 229
Misses 95 95
Partials 24 24Continue to review full report at Codecov.
|
Contributor
Author
|
tested working in v0.2.0-34, will cut new version 0.2.1 when this gets merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new versioning convention introduces git tags that start with v
this change will ensure that the leading v will be excluded when
packages are being created. eg.
GIT_TAG = TRAVIS_TAG = v0.2.0
then
VERSION = 0.2.0 = DOCKER_TAG and versioning in rpm/deb packages