feat: dfm-gherkin in progress #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
commented
Dec 12, 2019
| assert.NotNil(t, actual) | ||
|
|
||
| configManager.SyncConfig(mockDatafile2) | ||
| configManager.SyncConfig([]byte{}) |
There was a problem hiding this comment.
what's the purpose of this one?
| ln -s features/support/datafiles/ public | ||
| pushd services/datafile && nvm install && nvm use && npm install && popd | ||
| node services/datafile/ &> /dev/null & | ||
| popd No newline at end of file |
| Listeners map[string]int | ||
| UserProfileServiceType string | ||
| UPSMapping map[string]map[string]string | ||
| ScenarioID string |
There was a problem hiding this comment.
I remember we had scenarioId in the past, but why it's showing it as new line.
| } | ||
|
|
||
| // GetListenerCallbacks - Creates and returns listener callback array | ||
| func (c *TestProjectConfigManager) GetListenerCallbacks(apiOptions models.APIOptions) (listeners []func(notification notification.ProjectConfigUpdateNotification)) { |
There was a problem hiding this comment.
Need to revise this logic what explained in onTrack.
| * limitations under the License. * | ||
| ***************************************************************************/ | ||
|
|
||
| package optlyplugins |
There was a problem hiding this comment.
we don't really need to make this work in a separate file.
| timeout = time.Duration(*(configuration.Timeout)) * time.Millisecond | ||
| } | ||
|
|
||
| verify := func(wg *sync.WaitGroup) { |
There was a problem hiding this comment.
this whole logic can be revised as same as java-testapp. let's sync offline. need to increment and dec waitgroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.