-
Notifications
You must be signed in to change notification settings - Fork 19
fix(ticker): stop all tickers to prevent goroutine leak #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Succo, thanks for opening this PR! Can you please update your branch with master? |
|
Hey @pulak-opti No problem, it should be good |
|
Mmm I'm not sure the failed test are related to my review "Error: Input required and not supplied: token" Looks like a config issue |
pulak-opti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Mentioning @yasirfolio3 for a final check!
yasirfolio3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you please update the headers with the current year 2023 in all the files.
|
Yes |
|
Hi @Succo |
|
Should be good. |
|
I changed the user and force pushed the branch with the new author |
|
The fix is merged here #375. Thank you for your contribution |
According to https://pkg.go.dev/time#NewTicker
It is a good practice to Stop a ticker when it goes unused to release the ressources a goroutine in this case)