Skip to content

[FSSDK-8991]refact: Updating example code and sdkKey to use decide. #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2023
Merged

[FSSDK-8991]refact: Updating example code and sdkKey to use decide. #377

merged 3 commits into from
Jul 18, 2023

Conversation

@yasirfolio3
Copy link
Contributor

Summary

  • Updating example code and sdkKey to use decide.

Issues

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner July 11, 2023 22:27
jaeopt
jaeopt approved these changes Jul 18, 2023
View reviewed changes
Copy link

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 merged commit fc74b2b into master Jul 18, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-8991 branch July 18, 2023 16:38
Mat001 added a commit that referenced this pull request Oct 23, 2025
@Mat001
Update CMAB default cache size from 100 to 1000 to match Ruby SDK
d003b79 
- Changed DefaultCacheSize from 100 to 1000 in pkg/cmab/config.go
- Updated corresponding test in pkg/cmab/config_test.go
- Aligns with Ruby SDK default cache size (PR #377)
- All tests passing
@Mat001 Mat001 mentioned this pull request Oct 23, 2025
Merged
Mat001 added a commit that referenced this pull request Oct 23, 2025
@Mat001
Update CMAB default cache size from 100 to 1000 to match Ruby SDK (#424)
c1318f2 
- Changed DefaultCacheSize from 100 to 1000 in pkg/cmab/config.go
- Updated corresponding test in pkg/cmab/config_test.go
- Aligns with Ruby SDK default cache size (PR #377)
- All tests passing
Mat001 added a commit that referenced this pull request Oct 24, 2025
@Mat001
[FSSDK-11877] Increase cmab cache size to 10000 to align with odp cac…
9fd02f9 
…he size (#425)

* Update CMAB default cache size from 100 to 1000 to match Ruby SDK

- Changed DefaultCacheSize from 100 to 1000 in pkg/cmab/config.go
- Updated corresponding test in pkg/cmab/config_test.go
- Aligns with Ruby SDK default cache size (PR #377)
- All tests passing

* align cmab cache size with odp size - 10000

* Remove TestDefaultConstants test and unused time import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@yasirfolio3 yasirfolio3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yasirfolio3 @jaeopt