Skip to content

[FSSDK-11915] Fix Go Region EU problem #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
+2 −6
Merged

[FSSDK-11915] Fix Go Region EU problem #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9a408f
[FSSDK-11915] Fix Go Region EU problem
esrakartalOpt Oct 9, 2025
7cc8b96
Implement suggested change request
esrakartalOpt Oct 23, 2025
7b9a467
Merge branch 'master' of https://github.com/optimizely/go-sdk into es…
esrakartalOpt Oct 23, 2025
2e0638a
Fix test case and correct the default endpoint assertion
esrakartalOpt Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/event/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,6 @@ func NewBatchEventProcessor(options ...BPOptionConfig) *BatchEventProcessor {
p.BatchSize = DefaultBatchSize
}

if p.EventEndPoint == "" {
p.EventEndPoint = EventEndPoints["US"]
}

if p.BatchSize > p.MaxQueueSize {
p.logger.Warning(
fmt.Sprintf("Batch size %d is larger than queue size %d. Setting to defaults",
Expand Down
4 changes: 2 additions & 2 deletions pkg/event/processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func TestCustomEventProcessor_Create(t *testing.T) {
func TestEndPointOptionEventProcessor(t *testing.T) {
// Default end point
processor := NewBatchEventProcessor()
assert.Equal(t, EventEndPoints["US"], processor.EventEndPoint)
assert.Equal(t, "", processor.EventEndPoint)

customEndPoint := "https://logx.optimizely.com"
processor = NewBatchEventProcessor(
Expand All @@ -133,7 +133,7 @@ func TestEndPointOptionEventProcessor(t *testing.T) {
func TestEndPointOptionEU(t *testing.T) {
// Default end point
processor := NewBatchEventProcessor()
assert.Equal(t, EventEndPoints["US"], processor.EventEndPoint)
assert.Equal(t, "", processor.EventEndPoint)

euEndpoint := EventEndPoints["EU"]
processor = NewBatchEventProcessor(
Expand Down