Skip to content

Commit 00fbc21

Browse files
Update dodgy tests.
1 parent 35ff0ce commit 00fbc21

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2892,8 +2892,6 @@ public void getFeatureVariableValueReturnsDefaultValueWhenFeatureEnabledIsFalse(
28922892

28932893
Optimizely optimizely = optimizelyBuilder.withDecisionService(mockDecisionService).build();
28942894

2895-
Attribute attribute = new Attribute("Dummy","Dummy","Dummy");
2896-
28972895
FeatureDecision featureDecision = new FeatureDecision(multivariateExperiment, VARIATION_MULTIVARIATE_EXPERIMENT_GRED, FeatureDecision.DecisionSource.FEATURE_TEST);
28982896
doReturn(DecisionResponse.responseNoReasons(featureDecision)).when(mockDecisionService).getVariationForFeature(
28992897
FEATURE_FLAG_MULTI_VARIATE_FEATURE,

core-api/src/test/java/com/optimizely/ab/bucketing/DecisionServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@ public void getVariationWhitelistedPrecedesAudienceEval() throws Exception {
9898
experiment,
9999
optimizely.createUserContext(
100100
genericUserId,
101-
null),
101+
Collections.emptyMap()),
102102
validProjectConfig).getResult());
103103

104104
logbackVerifier.expectMessage(Level.INFO, "User \"" + whitelistedUserId + "\" is forced in variation \"vtag1\".");
105105

106106
// no attributes provided for a experiment that has an audience
107-
assertThat(decisionService.getVariation(experiment, optimizely.createUserContext(whitelistedUserId, null), validProjectConfig).getResult(), is(expectedVariation));
107+
assertThat(decisionService.getVariation(experiment, optimizely.createUserContext(whitelistedUserId, Collections.emptyMap()), validProjectConfig).getResult(), is(expectedVariation));
108108

109109
verify(decisionService).getWhitelistedVariation(eq(experiment), eq(whitelistedUserId));
110110
verify(decisionService, never()).getStoredVariation(eq(experiment), any(UserProfile.class), any(ProjectConfig.class));

0 commit comments

Comments
 (0)