Skip to content

Commit 225cd1e

Browse files
Update tests for more coverage.
1 parent f75c04a commit 225cd1e

File tree

1 file changed

+31
-7
lines changed

1 file changed

+31
-7
lines changed

core-api/src/test/java/com/optimizely/ab/OptimizelyUserContextTest.java

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,27 +1202,51 @@ public void setForcedDecisionWithRuleKeyTest() {
12021202
Collections.emptyMap());
12031203

12041204
optimizelyUserContext.setForcedDecision(flagKey, ruleKey, variationKey);
1205-
OptimizelyUserContext.ForcedDecision forcedDecision = optimizelyUserContext.forcedDecisionsMap.get(flagKey).get(ruleKey);
1206-
assertEquals(forcedDecision.getFlagKey(), flagKey);
1207-
assertEquals(forcedDecision.getRuleKey(), ruleKey);
1208-
assertEquals(forcedDecision.getVariationKey(), variationKey);
1205+
String foundVariationKey = optimizelyUserContext.getForcedDecision(flagKey, ruleKey);
1206+
assertEquals(variationKey, foundVariationKey);
1207+
}
1208+
1209+
@Test
1210+
public void setForcedDecisionsWithRuleKeyTest() {
1211+
String flagKey = "55555";
1212+
String ruleKey = "77777";
1213+
String ruleKey2 = "88888";
1214+
String variationKey = "33333";
1215+
String variationKey2 = "44444";
1216+
OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
1217+
optimizely,
1218+
userId,
1219+
Collections.emptyMap());
1220+
1221+
optimizelyUserContext.setForcedDecision(flagKey, ruleKey, variationKey);
1222+
optimizelyUserContext.setForcedDecision(flagKey, ruleKey2, variationKey2);
1223+
assertEquals(variationKey, optimizelyUserContext.getForcedDecision(flagKey, ruleKey));
1224+
assertEquals(variationKey2, optimizelyUserContext.getForcedDecision(flagKey, ruleKey2));
1225+
1226+
// Update first forcedDecision
1227+
optimizelyUserContext.setForcedDecision(flagKey, ruleKey, variationKey2);
1228+
assertEquals(variationKey2, optimizelyUserContext.getForcedDecision(flagKey, ruleKey));
12091229
}
12101230

12111231
@Test
12121232
public void setForcedDecisionWithoutRuleKeyTest() {
12131233
String flagKey = "55555";
12141234
String variationKey = "33333";
1235+
String updatedVariationKey = "55555";
12151236
OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
12161237
optimizely,
12171238
userId,
12181239
Collections.emptyMap());
12191240

12201241
optimizelyUserContext.setForcedDecision(flagKey, variationKey);
1221-
OptimizelyUserContext.ForcedDecision forcedDecision = optimizelyUserContext.forcedDecisionsMapWithNoRuleKey.get(flagKey);
1222-
assertEquals(forcedDecision.getFlagKey(), flagKey);
1223-
assertEquals(forcedDecision.getVariationKey(), variationKey);
1242+
assertEquals(variationKey, optimizelyUserContext.getForcedDecision(flagKey));
1243+
1244+
// Update forcedDecision
1245+
optimizelyUserContext.setForcedDecision(flagKey, updatedVariationKey);
1246+
assertEquals(updatedVariationKey, optimizelyUserContext.getForcedDecision(flagKey));
12241247
}
12251248

1249+
12261250
@Test
12271251
public void setForcedDecisionWithoutRuleKeyTestSdkNotReady() {
12281252
String flagKey = "55555";

0 commit comments

Comments
 (0)