Removing SDK Ready checks from FD implementation and tests.

Author: The-inside-man

core-api/src/main/java/com/optimizely/ab/OptimizelyUserContext.java

@@ -198,10 +198,6 @@ public void trackEvent(@Nonnull String eventName) throws UnknownEventTypeExcepti
      */
     public Boolean setForcedDecision(@Nonnull OptimizelyDecisionContext optimizelyDecisionContext,
                                      @Nonnull OptimizelyForcedDecision optimizelyForcedDecision) {
-        if (optimizely.getOptimizelyConfig() == null) {
-            logger.error("Optimizely SDK not ready.");
-            return false;
-        }
         // Check if the forcedDecisionsMap has been initialized yet or not
         if (forcedDecisionsMap == null ){
             // Thread-safe implementation of HashMap
@@ -219,10 +215,6 @@ public Boolean setForcedDecision(@Nonnull OptimizelyDecisionContext optimizelyDe
      */
     @Nullable
     public OptimizelyForcedDecision getForcedDecision(@Nonnull OptimizelyDecisionContext optimizelyDecisionContext) {
-        if (optimizely.getOptimizelyConfig() == null) {
-            logger.error("Optimizely SDK not ready.");
-            return null;
-        }
         return findForcedDecision(optimizelyDecisionContext);
     }
 
@@ -247,11 +239,6 @@ public OptimizelyForcedDecision findForcedDecision(@Nonnull OptimizelyDecisionCo
      * @return Returns a boolean, true if successfully removed, otherwise false
      */
     public boolean removeForcedDecision(@Nonnull OptimizelyDecisionContext optimizelyDecisionContext) {
-        if (optimizely.getOptimizelyConfig() == null) {
-            logger.error("Optimizely SDK not ready.");
-            return false;
-        }
-
         try {
             if (forcedDecisionsMap != null) {
                 if (forcedDecisionsMap.remove(optimizelyDecisionContext.getKey()) != null) {
@@ -271,10 +258,6 @@ public boolean removeForcedDecision(@Nonnull OptimizelyDecisionContext optimizel
      * @return Returns a boolean, True if successfully, otherwise false
      */
     public boolean removeAllForcedDecisions() {
-        if (optimizely.getProjectConfig() == null) {
-            logger.error("Optimizely SDK not ready.");
-            return false;
-        }
         // Clear both maps for with and without ruleKey
         if (forcedDecisionsMap != null) {
             forcedDecisionsMap.clear();

core-api/src/test/java/com/optimizely/ab/OptimizelyUserContextTest.java

@@ -1263,21 +1263,6 @@ public void setForcedDecisionWithoutRuleKeyTest() {
     }
 
 
-    @Test
-    public void setForcedDecisionWithoutRuleKeyTestSdkNotReady() {
-        String flagKey = "55555";
-        String variationKey = "33333";
-        Optimizely optimizely = new Optimizely.Builder().build();
-        OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
-            optimizely,
-            userId,
-            Collections.emptyMap());
-
-        OptimizelyDecisionContext optimizelyDecisionContext = new OptimizelyDecisionContext(flagKey, null);
-        OptimizelyForcedDecision optimizelyForcedDecision = new OptimizelyForcedDecision(variationKey);
-        assertFalse(optimizelyUserContext.setForcedDecision(optimizelyDecisionContext, optimizelyForcedDecision));
-    }
-
     @Test
     public void getForcedVariationWithRuleKey() {
         String flagKey = "55555";
@@ -1330,22 +1315,6 @@ public void getForcedVariationWithoutRuleKey() {
         assertEquals(variationKey, optimizelyUserContext.getForcedDecision(optimizelyDecisionContext).getVariationKey());
     }
 
-    @Test
-    public void getForcedVariationWithoutRuleKeySdkNotReady() {
-        String flagKey = "55555";
-        String variationKey = "33333";
-        Optimizely optimizely = new Optimizely.Builder().build();
-        OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
-            optimizely,
-            userId,
-            Collections.emptyMap());
-
-        OptimizelyDecisionContext optimizelyDecisionContext = new OptimizelyDecisionContext(flagKey, null);
-        OptimizelyForcedDecision optimizelyForcedDecision = new OptimizelyForcedDecision(variationKey);
-
-        optimizelyUserContext.setForcedDecision(optimizelyDecisionContext, optimizelyForcedDecision);
-        assertNull(optimizelyUserContext.getForcedDecision(optimizelyDecisionContext));
-    }
 
     @Test
     public void failedGetForcedDecisionWithoutRuleKey() {
@@ -1434,22 +1403,6 @@ public void removeForcedDecisionWithIncorrectFlagKey() {
         assertFalse(optimizelyUserContext.removeForcedDecision(incorrectOptimizelyDecisionContext));
     }
 
-    @Test
-    public void removeForcedDecisionWithoutRuleKeySdkNotReady() {
-        String flagKey = "flag2";
-        String variationKey = "33333";
-        Optimizely optimizely = new Optimizely.Builder().build();
-        OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
-            optimizely,
-            userId,
-            Collections.emptyMap());
-
-        OptimizelyDecisionContext optimizelyDecisionContext = new OptimizelyDecisionContext(flagKey, null);
-        OptimizelyForcedDecision optimizelyForcedDecision = new OptimizelyForcedDecision(variationKey);
-
-        optimizelyUserContext.setForcedDecision(optimizelyDecisionContext, optimizelyForcedDecision);
-        assertFalse(optimizelyUserContext.removeForcedDecision(optimizelyDecisionContext));
-    }
 
     @Test
     public void removeForcedDecisionWithIncorrectFlagKeyButSimilarRuleKey() {
@@ -1487,23 +1440,6 @@ public void removeAllForcedDecisions() {
         assertTrue(optimizelyUserContext.removeAllForcedDecisions());
     }
 
-    @Test
-    public void removeAllForcedDecisionsSdkNotReady() {
-        String flagKey = "55555";
-        String ruleKey = "77777";
-        String variationKey = "33333";
-        Optimizely optimizely = new Optimizely.Builder().build();
-        OptimizelyUserContext optimizelyUserContext = new OptimizelyUserContext(
-            optimizely,
-            userId,
-            Collections.emptyMap());
-
-        OptimizelyDecisionContext optimizelyDecisionContext = new OptimizelyDecisionContext(flagKey, ruleKey);
-        OptimizelyForcedDecision optimizelyForcedDecision = new OptimizelyForcedDecision(variationKey);
-
-        optimizelyUserContext.setForcedDecision(optimizelyDecisionContext, optimizelyForcedDecision);
-        assertFalse(optimizelyUserContext.removeAllForcedDecisions());
-    }
 
     @Test
     public void findValidatedForcedDecisionWithRuleKey() {