Skip to content

Commit 46cc712

Browse files
Update conditions to use Stringbuilder instead of StringJoiner for compatibility with Android.
1 parent 70a42c6 commit 46cc712

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

core-api/src/main/java/com/optimizely/ab/config/audience/AndCondition.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,13 @@ public String getOperandOrId() {
7676

7777
@Override
7878
public String toJson() {
79-
StringJoiner s = new StringJoiner(", ", "[", "]");
80-
s.add("\"and\"");
79+
StringBuilder s = new StringBuilder();
80+
s.append("[\"and\"");
8181
for (int i = 0; i < conditions.size(); i++) {
82-
s.add(conditions.get(i).toJson());
82+
s.append(conditions.get(i).toJson());
83+
s.append(", ");
8384
}
85+
s.append("]");
8486
return s.toString();
8587
}
8688

core-api/src/main/java/com/optimizely/ab/config/audience/NotCondition.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ public String getOperandOrId() {
5656

5757
@Override
5858
public String toJson() {
59-
StringJoiner s = new StringJoiner(", ","[","]");
60-
s.add("\"not\"");
61-
s.add(condition.toJson());
59+
StringBuilder s = new StringBuilder();
60+
s.append("[\"not\"");
61+
s.append(condition.toJson());
62+
s.append("]");
6263
return s.toString();
6364
}
6465

core-api/src/main/java/com/optimizely/ab/config/audience/OrCondition.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,13 @@ public String getOperandOrId() {
7474

7575
@Override
7676
public String toJson() {
77-
StringJoiner s = new StringJoiner(", ", "[", "]");
78-
s.add("\"or\"");
77+
StringBuilder s = new StringBuilder();
78+
s.append("[\"or\"");
7979
for (int i = 0; i < conditions.size(); i++) {
80-
s.add(conditions.get(i).toJson());
80+
s.append(conditions.get(i).toJson());
81+
s.append(", ");
8182
}
83+
s.append("]");
8284
return s.toString();
8385
}
8486

0 commit comments

Comments
 (0)