Skip to content

Commit bd41dd1

Browse files
Update constructor to use ? instead of object - reverting
1 parent cdaa2e0 commit bd41dd1

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ private Boolean isFeatureEnabled(@Nonnull ProjectConfig projectConfig,
422422
return false;
423423
}
424424

425-
Map<String, Object> copiedAttributes = copyAttributes(attributes);
425+
Map<String, ?> copiedAttributes = copyAttributes(attributes);
426426
FeatureDecision.DecisionSource decisionSource = FeatureDecision.DecisionSource.ROLLOUT;
427427
FeatureDecision featureDecision = decisionService.getVariationForFeature(featureFlag, createUserContext(userId, copiedAttributes), projectConfig).getResult();
428428
Boolean featureEnabled = false;
@@ -732,7 +732,7 @@ <T> T getFeatureVariableValueForType(@Nonnull String featureKey,
732732
}
733733

734734
String variableValue = variable.getDefaultValue();
735-
Map<String, Object> copiedAttributes = copyAttributes(attributes);
735+
Map<String, ?> copiedAttributes = copyAttributes(attributes);
736736
FeatureDecision featureDecision = decisionService.getVariationForFeature(featureFlag, createUserContext(userId, copiedAttributes), projectConfig).getResult();
737737
Boolean featureEnabled = false;
738738
if (featureDecision.variation != null) {
@@ -865,7 +865,7 @@ public OptimizelyJSON getAllFeatureVariables(@Nonnull String featureKey,
865865
return null;
866866
}
867867

868-
Map<String, Object> copiedAttributes = copyAttributes(attributes);
868+
Map<String, ?> copiedAttributes = copyAttributes(attributes);
869869
FeatureDecision featureDecision = decisionService.getVariationForFeature(featureFlag, createUserContext(userId, copiedAttributes), projectConfig, Collections.emptyList()).getResult();
870870
Boolean featureEnabled = false;
871871
Variation variation = featureDecision.variation;
@@ -935,7 +935,7 @@ public List<String> getEnabledFeatures(@Nonnull String userId, @Nonnull Map<Stri
935935
return enabledFeaturesList;
936936
}
937937

938-
Map<String, Object> copiedAttributes = copyAttributes(attributes);
938+
Map<String, ?> copiedAttributes = copyAttributes(attributes);
939939
for (FeatureFlag featureFlag : projectConfig.getFeatureFlags()) {
940940
String featureKey = featureFlag.getKey();
941941
if (isFeatureEnabled(projectConfig, featureKey, userId, copiedAttributes))
@@ -951,7 +951,7 @@ public List<String> getEnabledFeatures(@Nonnull String userId, @Nonnull Map<Stri
951951
public Variation getVariation(@Nonnull Experiment experiment,
952952
@Nonnull String userId) throws UnknownExperimentException {
953953

954-
return getVariation(experiment, userId, Collections.<String, String>emptyMap());
954+
return getVariation(experiment, userId, Collections.emptyMap());
955955
}
956956

957957
@Nullable
@@ -966,7 +966,7 @@ private Variation getVariation(@Nonnull ProjectConfig projectConfig,
966966
@Nonnull Experiment experiment,
967967
@Nonnull String userId,
968968
@Nonnull Map<String, ?> attributes) throws UnknownExperimentException {
969-
Map<String, Object> copiedAttributes = copyAttributes(attributes);
969+
Map<String, ?> copiedAttributes = copyAttributes(attributes);
970970
Variation variation = decisionService.getVariation(experiment, createUserContext(userId, copiedAttributes), projectConfig).getResult();
971971
String notificationType = NotificationCenter.DecisionNotificationType.AB_TEST.toString();
972972

@@ -1150,7 +1150,7 @@ public OptimizelyConfig getOptimizelyConfig() {
11501150
* @return An OptimizelyUserContext associated with this OptimizelyClient.
11511151
*/
11521152
public OptimizelyUserContext createUserContext(@Nonnull String userId,
1153-
@Nonnull Map<String, Object> attributes) {
1153+
@Nonnull Map<String, ?> attributes) {
11541154
if (userId == null) {
11551155
logger.warn("The userId parameter must be nonnull.");
11561156
return null;
@@ -1360,7 +1360,7 @@ public Variation getFlagVariationByKey(String flagKey, String variationKey) {
13601360
* @param attributes map to copy
13611361
* @return copy of attributes
13621362
*/
1363-
private Map<String, Object> copyAttributes(Map<String, ?> attributes) {
1363+
private Map<String, ?> copyAttributes(Map<String, ?> attributes) {
13641364
Map<String, Object> copiedAttributes = null;
13651365
if (attributes != null) {
13661366
copiedAttributes = new HashMap<>(attributes);

core-api/src/main/java/com/optimizely/ab/OptimizelyUserContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static class ForcedDecision {
5959

6060
public OptimizelyUserContext(@Nonnull Optimizely optimizely,
6161
@Nonnull String userId,
62-
@Nonnull Map<String, Object> attributes) {
62+
@Nonnull Map<String, ?> attributes) {
6363
this.optimizely = optimizely;
6464
this.userId = userId;
6565
if (attributes != null) {

0 commit comments

Comments
 (0)