Skip to content

feat: Upgrade TS to 4.0.3 in datafile-manager #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2021
Merged

feat: Upgrade TS to 4.0.3 in datafile-manager #669

merged 5 commits into from
Jun 1, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented May 24, 2021 •
edited
Loading

Summary

  • Upgrade TS to version 4.0.3 and jest to version 27.0.1 in datafile-manager module
  • Fix existing unit tests

Test plan

Existing unit tests

@yavorona yavorona added the WIP label May 24, 2021
@yavorona yavorona self-assigned this May 24, 2021
@yavorona yavorona requested a review from a team as a code owner May 24, 2021 22:57
@coveralls
Copy link

coveralls commented May 24, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 97.001% when pulling 4bb137f on pnguen/upgrade-ts-in-datafile-manager into 377ffc1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.001% when pulling 5a006c9 on pnguen/upgrade-ts-in-datafile-manager into e760efd on master.

@yavorona yavorona removed the WIP label May 28, 2021
@yavorona yavorona removed their assignment May 28, 2021
@yavorona yavorona merged commit 64d77e5 into master Jun 1, 2021
@yavorona yavorona deleted the pnguen/upgrade-ts-in-datafile-manager branch June 1, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@keppel2 keppel2 keppel2 approved these changes

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yavorona @coveralls @keppel2 @zashraf1985 @optimizely-codereview-bot