Skip to content

feat: Upgrade TS to 4.0.3 in datafile-manager #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2021
Merged

feat: Upgrade TS to 4.0.3 in datafile-manager #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a006c9
Upgrade TS
yavorona May 21, 2021
264a2ba
attempting to fix test failure
zashraf1985 May 27, 2021
d512381
Merge branch 'master' into pnguen/upgrade-ts-in-datafile-manager
zashraf1985 May 27, 2021
db115d2
another attempt to fix tests
zashraf1985 May 27, 2021
4bb137f
fixed package lock
zashraf1985 May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ jobs:
- <<: *packagetest
before_install: cd packages/logging
- <<: *packagetest
before_script: npm install "@react-native-async-storage/async-storage"
before_install: cd packages/datafile-manager

- stage: 'Source Clear'
Expand Down
9 changes: 5 additions & 4 deletions packages/datafile-manager/__test__/httpPollingDatafileManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ describe('httpPollingDatafileManager', () => {
headers: {},
});
await responsePromise;
await advanceTimersByTime(0);
expect(makeGetRequestSpy).toBeCalledTimes(2);
});
});
Expand Down Expand Up @@ -334,7 +335,7 @@ describe('httpPollingDatafileManager', () => {
await manager.onReady();
expect(JSON.parse(manager.get())).toEqual({ foo: 'bar' });

advanceTimersByTime(1000);
await advanceTimersByTime(1000);

expect(manager.responsePromises.length).toBe(2);
manager.stop();
Expand Down Expand Up @@ -409,7 +410,7 @@ describe('httpPollingDatafileManager', () => {
// First response promise was for the initial 200 response
expect(manager.responsePromises.length).toBe(1);
// Trigger the queued update
advanceTimersByTime(1000);
await advanceTimersByTime(1000);
// Second response promise is for the 304 response
expect(manager.responsePromises.length).toBe(2);
await manager.responsePromises[1];
Expand All @@ -436,7 +437,7 @@ describe('httpPollingDatafileManager', () => {
manager.start();
await manager.onReady();
const makeGetRequestSpy = jest.spyOn(manager, 'makeGetRequest');
advanceTimersByTime(1000);
await advanceTimersByTime(1000);
expect(makeGetRequestSpy).toBeCalledTimes(1);
const firstCall = makeGetRequestSpy.mock.calls[0];
const headers = firstCall[1];
Expand Down Expand Up @@ -468,7 +469,7 @@ describe('httpPollingDatafileManager', () => {
expect(makeGetRequestSpy).toBeCalledTimes(1);

// But after another 5 seconds, another request should be made
advanceTimersByTime(5000);
await advanceTimersByTime(5000);
expect(makeGetRequestSpy).toBeCalledTimes(2);
});

Expand Down
Loading