Evaluate stale getter deps only once #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move logic around to avoid evaluating dependencies twice in certain code path
src/evaluator.js
Outdated
Contributor
There was a problem hiding this comment.
pretty minor, but this could be put inside the isEqual if block
Contributor
Author
There was a problem hiding this comment.
Contributor
|
This is causing an evaluator test to fail. Will look into it. |
Contributor
|
@loganlinn would you mind merging master so that CI will run properly. |
jordangarcia
added a commit
that referenced
this pull request
May 14, 2015
Evaluate stale getter deps only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move logic around to avoid evaluating dependencies twice in certain code path