Skip to content

Conversation

@jordangarcia
Copy link
Contributor

  • Refactor how registerStores work - get rid of silent option which was causing strange observation behavior when passed in as true
  • add back registerStore method which was deprecated and put a console.warn with deprecation notice
  • Get test coverage to 100%
  • Add grunt script to run on CI to do coverage and send results to coveralls
  • add coveralls coverage badge to README

@bhamodi

TODO:

- [ ] implement karma running with grunt so we can have multiple karma
configs (need specific settings for coverage)
- [ ] 100% test coverage or ignore utils file
- [ ] setup coveralls with grunt-karma-coveralls
- [ ] add coveralls badge to README
Fix bug with `Number.MAX_SAFE_INTEGER` which is es6 standard.  Use
`Number.MAX_NUMBER` instead

Fix issue with throwing an error during a dispatch messing up the
logging groups
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe21883 on jordan/blankets-karma into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ccec321 on jordan/blankets-karma into * on master*.

@jordangarcia jordangarcia self-assigned this May 10, 2015
Update README with local dev section

Update README API docs to reflect the removal of the `silent` option
from `Reactor#registerStores`
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1d44f52 on jordan/blankets-karma into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1d44f52 on jordan/blankets-karma into * on master*.

jordangarcia added a commit that referenced this pull request May 10, 2015
Add code coverage via istanbul and report on coveralls.io
@jordangarcia jordangarcia merged commit bbd6c85 into master May 10, 2015
@jordangarcia jordangarcia deleted the jordan/blankets-karma branch May 10, 2015 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants