Fixed last 10 lint warnings.

grunt/sauce.js

@@ -1,3 +1,4 @@
+var each = require('../src/utils').each
 var sauceConfig = {
   username: 'nuclearjs',
   accessKey: process.env.SAUCE_ACCESS_KEY,
@@ -70,14 +71,14 @@ var batches = {
   },
 }
 
-for (var key in batches) {
+each(batches, function(value, key) {
   exports[key] = {
     sauceLabs: sauceConfig,
     // mobile emulators are really slow
     captureTimeout: 300000,
     browserNoActivityTimeout: 300000,
-    customLaunchers: batches[key],
-    browsers: Object.keys(batches[key]),
+    customLaunchers: value,
+    browsers: Object.keys(value),
     reporters: ['progress', 'saucelabs'],
   }
-}
+})

src/utils.js

@@ -105,8 +105,8 @@ exports.each = function(collection, iteratee, context) {
 
   if (context) {
     origIteratee = iteratee
-    iteratee = function(value, index, collection) {
-      return origIteratee.call(context, value, index, collection)
+    iteratee = function(value, index, innerCollection) {
+      return origIteratee.call(context, value, index, innerCollection)
     }
   }
 

tests/evaluator-tests.js

@@ -87,9 +87,9 @@ describe('Evaluator', () => {
       currentProjectGetter = [
         ['projects'],
         ['session', 'currentProjectId'],
-        (projects, currentProjectId) => {
+        (allProjects, currentProjectId) => {
           currentProjectSpy()
-          return projects.get(currentProjectId)
+          return allProjects.get(currentProjectId)
         },
       ]
       currentProjectDescriptionGetter = [
@@ -126,7 +126,7 @@ describe('Evaluator', () => {
     it('should prevent nested evaluate calls', () => {
       var nestedEvaluateGetter = [
         currentProjectGetter,
-        (projects) => {
+        () => {
           return evaluator.evaluate(state, currentProjectDescriptionGetter)
         },
       ]
@@ -168,8 +168,8 @@ describe('Evaluator', () => {
       var currentProjectGetter = [
         ['projects'],
         ['session', 'currentProjectId'],
-        (projects, currentProjectId) => {
-          return projects.get(currentProjectId)
+        (allProjects, currentProjectId) => {
+          return allProjects.get(currentProjectId)
         },
       ]
 
@@ -179,7 +179,7 @@ describe('Evaluator', () => {
       var result2 = evaluator.evaluate(state, currentProjectGetter)
       expect(result2).toBe(proj1)
       // update state test the `hasStaleValue` codepath
-      var state1 = state.update('projects', projects => projects.set(3, proj3))
+      var state1 = state.update('projects', allProjects => allProjects.set(3, proj3))
 
       var result3 = evaluator.evaluate(state1, currentProjectGetter)
       expect(result3).toBe(proj1)

tests/store-tests.js

@@ -20,11 +20,11 @@ describe('Store', () => {
 
         initialize: function() {
           this.on('addExperiments', (state, payload) => {
-            return state.withMutations(state => {
+            return state.withMutations(innerState => {
               payload.data.forEach(item => {
-                state.setIn(['experiments', item.id], Map(item))
+                innerState.setIn(['experiments', item.id], Map(item))
               })
-              return state
+              return innerState
             })
           })
 

tests/utils-tests.js

@@ -116,9 +116,11 @@ describe('Utils', () => {
     })
 
     it('identifies instances as Object types', () => {
+      /* eslint-disable no-new-wrappers */
       expect(Utils.isObject(new Number(0))).toBe(true)
       expect(Utils.isObject(new String(''))).toBe(true)
       expect(Utils.isObject(new Boolean(''))).toBe(true)
+      /* eslint-enable no-new-wrappers */
     })
   })