Helm Values yaml documentation #9
Conversation
mikechu-optimizely
added
the
documentation
|
@msohailhussain Am I good to merge this to main? |
|
Note: There are |
I will review today. Please wait. |
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
mostly looks good please address my comments.
|
@msohailhussain I'm ready for a second code review I was using this command to test |
| Run the following in a *nix terminal to access the running | ||
| {{- if contains "NodePort" .Values.service.type }} | ||
| {{- " NodePort service endpoint" }} | ||
| export NODE_PORT=$(kubectl get --namespace {{ .Release.Namespace }} -o jsonpath="{.spec.ports[0].nodePort}" services {{ include "optimizely-agent.fullname" . }}) | ||
| export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath="{.items[0].status.addresses[0].address}") | ||
| echo http://$NODE_IP:$NODE_PORT | ||
| {{- else if contains "LoadBalancer" .Values.service.type }} | ||
| {{- " LoadBalancer service endpoint" }} | ||
| NOTE: It may take a few minutes for the LoadBalancer IP to be available. | ||
| You can watch the status of by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "optimizely-agent.fullname" . }}' | ||
| export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "optimizely-agent.fullname" . }} --template "{{"{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}"}}") | ||
| echo http://$SERVICE_IP:{{ .Values.service.port }} | ||
| {{- else if contains "ClusterIP" .Values.service.type }} | ||
| {{- " ClusterIP service IP address" }} | ||
| export CLUSTER_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "optimizely-agent.fullname" . }} -o jsonpath='{.spec.clusterIP}') | ||
| echo http://$CLUSTER_IP:8080 | ||
| {{- end }} |
There was a problem hiding this comment.
@msohailhussain I thought it was good to keep the outputs from the other service types. 😄
My research points to our need to run kubectl commands to access info from the running deployments like IP, Ports, etc. It appears that helm resolves templates earlier before the deployment is necessarily online ie no access to post-install values in the NOTES. ...again, from what I can tell.
I'm certain @yasirfolio3 can take this further than my knowledge/experience.
There was a problem hiding this comment.
Let's have a ticket, and will fix later. For now it's good we may release as it is.
|
lgtm |
No description provided.