🖊️ Fixed Code Coverage

Author: oakbani

tests/ProjectConfigTest.php

@@ -23,13 +23,17 @@
 use Optimizely\Entity\Audience;
 use Optimizely\Entity\Event;
 use Optimizely\Entity\Experiment;
+use Optimizely\Entity\FeatureFlag;
+use Optimizely\Entity\Rollout;
 use Optimizely\Entity\Group;
 use Optimizely\Entity\Variation;
 use Optimizely\ErrorHandler\NoOpErrorHandler;
 use Optimizely\Exceptions\InvalidAttributeException;
 use Optimizely\Exceptions\InvalidAudienceException;
 use Optimizely\Exceptions\InvalidEventException;
 use Optimizely\Exceptions\InvalidExperimentException;
+use Optimizely\Exceptions\InvalidFeatureFlagException;
+use Optimizely\Exceptions\InvalidRolloutException;
 use Optimizely\Exceptions\InvalidGroupException;
 use Optimizely\Exceptions\InvalidVariationException;
 use Optimizely\Logger\DefaultLogger;
@@ -315,6 +319,30 @@ public function testGetExperimentInvalidId()
         $this->assertEquals(new Experiment(), $this->config->getExperimentFromId('42'));
     }
 
+    public function testGetFeatureFlagInvalidKey()
+    {
+        $this->loggerMock->expects($this->once())
+            ->method('log')
+            ->with(Logger::ERROR, 'FeatureFlag Key "42" is not in datafile.');
+        $this->errorHandlerMock->expects($this->once())
+            ->method('handleError')
+            ->with(new InvalidFeatureFlagException('Provided feature flag is not in datafile.'));
+
+        $this->assertEquals(new FeatureFlag(), $this->config->getFeatureFlagFromKey('42'));
+    }
+
+        public function testGetRolloutInvalidId()
+    {
+        $this->loggerMock->expects($this->once())
+            ->method('log')
+            ->with(Logger::ERROR, 'Rollout ID "42" is not in datafile.');
+        $this->errorHandlerMock->expects($this->once())
+            ->method('handleError')
+            ->with(new InvalidRolloutException('Provided rollout is not in datafile.'));
+
+        $this->assertEquals(new Rollout(), $this->config->getRolloutFromId('42'));
+    }
+
     public function testGetEventValidKey()
     {
         $event = $this->config->getEvent('purchase');

tests/UtilsTests/ValidatorTest.php

@@ -21,10 +21,20 @@
 use Optimizely\Logger\NoOpLogger;
 use Optimizely\ProjectConfig;
 use Optimizely\Utils\Validator;
-
+use Monolog\Logger;
 
 class ValidatorTest extends \PHPUnit_Framework_TestCase
 {
+    protected $loggerMock;
+
+    protected function setUp()
+    {
+        // Mock Logger
+        $this->loggerMock = $this->getMockBuilder(NoOpLogger::class)
+        ->setMethods(array('log'))
+        ->getMock();
+    }
+
     public function testValidateJsonSchemaValidFile()
     {
         $this->assertTrue(Validator::validateJsonSchema(DATAFILE));
@@ -42,6 +52,15 @@ public function testValidateJsonSchemaNoJsonContent()
         $this->assertFalse(Validator::validateJsonSchema($invalidDatafile));
     }
 
+    public function testValidateJsonSchemaInvalidJsonWithLogger(){
+        $invalidDatafile = '{"key1": "val1"}';
+        $this->loggerMock->expects($this->at(0))
+        ->method('log')
+        ->with(Logger::DEBUG,"JSON does not validate. Violations:\n");
+        $this->assertFalse(Validator::validateJsonSchema($invalidDatafile, $this->loggerMock));
+        
+    }
+
     public function testAreAttributesValidValidAttributes()
     {
         // Empty attributes