✏️ nits addressed

Author: oakbani

src/Optimizely/Entity/Variation.php

@@ -50,7 +50,7 @@ public function __construct($id = null, $key = null, $variableUsageInstances = [
         $this->_id = $id;
         $this->_key = $key;
 
-        $this->_variableUsageInstances = ConfigParser::generateMap($variableUsageInstances,null,VariableUsage::class);
+        $this->_variableUsageInstances = ConfigParser::generateMap($variableUsageInstances, null, VariableUsage::class);
 
         if(!empty($this->_variableUsageInstances)){
             foreach(array_values($this->_variableUsageInstances) as $variableUsage){
@@ -96,7 +96,7 @@ public function getVariables(){
     }
 
     public function setVariables($variableUsageInstances){
-        $this->_variableUsageInstances = ConfigParser::generateMap($variableUsageInstances,null,VariableUsage::class);
+        $this->_variableUsageInstances = ConfigParser::generateMap($variableUsageInstances, null , VariableUsage::class);
 
         if(!empty($this->_variableUsageInstances)){
             foreach(array_values($this->_variableUsageInstances) as $variableUsage){

src/Optimizely/Event/Builder/Params.php

@@ -23,15 +23,15 @@
 define('REVISION', 'revision');
 define('EXPERIMENT_ID', 'experiment_id');
 define('VARIATION_ID', 'variation_id');
-define('CAMPAIGN_ID','campaign_id');
+define('CAMPAIGN_ID', 'campaign_id');
 define('VISITOR_ID', 'visitor_id');
 define('DECISIONS', 'decisions');
 define('EVENTS', 'events');;
 define('CLIENT_ENGINE', 'client_name');
 define('CLIENT_VERSION', 'client_version');
 define('CUSTOM_ATTRIBUTE_FEATURE_TYPE','custom');
-define('ACTIVATE_EVENT_KEY','campaign_activated');
-define('SNAPSHOTS','snapshots');
+define('ACTIVATE_EVENT_KEY', 'campaign_activated');
+define('SNAPSHOTS', 'snapshots');
 define('ATTRIBUTES', 'attributes');
 define('KEY', 'key');
 define('TYPE', 'type');

src/Optimizely/ProjectConfig.php

@@ -309,8 +309,8 @@ public function getExperimentFromId($experimentId)
     }
 
     /**
-     * @param  String $featureKey 
-     * @return FeatureFlag
+     * @param  String $featureKey Key of the feature flag
+     * @return FeatureFlag Entity corresponding to the key.
      */
     public function getFeatureFlagFromKey($featureKey)
     {
@@ -326,7 +326,6 @@ public function getFeatureFlagFromKey($featureKey)
     /**
      * @param  String $rolloutId 
      * @return Rollout
-     * 
      */
     public function getRolloutFromId($rolloutId)
     {

src/Optimizely/Utils/EventTagUtils.php

@@ -65,30 +65,30 @@ public static function getNumericValue($eventTags, LoggerInterface $logger = nul
 
         if (!$eventTags) {
             if($logger)
-                $logger->log(Logger::DEBUG,"Event tags is undefined.");
+                $logger->log(Logger::DEBUG, "Event tags is undefined.");
             return null;
         } else if (!is_array($eventTags)) {
             if($logger)
-                $logger->log(Logger::DEBUG,"Event tags is not a dictionary.");
+                $logger->log(Logger::DEBUG, "Event tags is not a dictionary.");
             return null;
         } else if (!isset($eventTags[self::NUMERIC_EVENT_METRIC_NAME])) {
             if($logger)
-                $logger->log(Logger::DEBUG,"The numeric metric key is not defined in the event tags or is null.");
+                $logger->log(Logger::DEBUG, "The numeric metric key is not defined in the event tags or is null.");
             return null;
         } else if (!is_numeric($eventTags[self::NUMERIC_EVENT_METRIC_NAME])) {
             if($logger)
-                $logger->log(Logger::DEBUG,"Numeric metric value is not an integer or float, or is not a numeric string.");
+                $logger->log(Logger::DEBUG, "Numeric metric value is not an integer or float, or is not a numeric string.");
             return null;
         } else if(is_nan($eventTags[self::NUMERIC_EVENT_METRIC_NAME]) || is_infinite(floatval($eventTags[self::NUMERIC_EVENT_METRIC_NAME]))){
             if($logger)
-                $logger->log(Logger::DEBUG,"Provided numeric value is in an invalid format.");
+                $logger->log(Logger::DEBUG, "Provided numeric value is in an invalid format.");
             return null;
         }
 
         $rawValue = $eventTags[self::NUMERIC_EVENT_METRIC_NAME];
         // # Log the final numeric metric value
         if($logger){
-            $logger->log(Logger::INFO,"The numeric metric value {$rawValue} will be sent to results.");
+            $logger->log(Logger::INFO, "The numeric metric value {$rawValue} will be sent to results.");
         } 
 
         return floatval($rawValue);

src/Optimizely/Utils/Validator.php

@@ -17,11 +17,10 @@
 namespace Optimizely\Utils;
 
 use JsonSchema;
+use Monolog\Logger;
 use Optimizely\Entity\Experiment;
-use Optimizely\ProjectConfig;
 use Optimizely\Logger\LoggerInterface;
-use Monolog\Logger;
-
+use Optimizely\ProjectConfig;
 
 class Validator
 {
@@ -42,9 +41,9 @@ public static function validateJsonSchema($datafile, LoggerInterface $logger = n
             return true;
         } else {
             if($logger){
-                $logger->log(Logger::DEBUG,"JSON does not validate. Violations:\n");;
+                $logger->log(Logger::DEBUG, "JSON does not validate. Violations:\n");;
                 foreach ($validator->getErrors() as $error) {
-                   $logger->log(Logger::DEBUG,"[%s] %s\n", $error['property'], $error['message']);
+                   $logger->log(Logger::DEBUG, "[%s] %s\n", $error['property'], $error['message']);
                }
            }
 

tests/DecisionServiceTests/DecisionServiceTest.php

@@ -139,7 +139,7 @@ public function testGetVariationReturnsWhitelistedVariation()
 
     public function testGetVariationReturnsWhitelistedVariationForGroupedExperiment()
     {
-        $expectedVariation = new Variation('7722260071', 'group_exp_1_var_1',[
+        $expectedVariation = new Variation('7722260071', 'group_exp_1_var_1', [
                 [
                   "id" => "155563",
                   "value" => "groupie_1_v1"