refact(API): Validates empty user ID as valid. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Optimizely/ProjectConfig.php
Outdated
| if (strlen($userId) == 0) { | ||
| $this->_logger->log(Logger::DEBUG, 'User ID is invalid'); | ||
| // check for empty string user ID | ||
| if (!is_string($userId)) { |
Contributor
There was a problem hiding this comment.
Why we are not using validateInputs
mikeproeng37
approved these changes
Nov 26, 2018
src/Optimizely/Optimizely.php
Outdated
| self::USER_ID => $userId | ||
| ] | ||
| ) | ||
| ) { |
Contributor
There was a problem hiding this comment.
nit: This indentation seems weird to me. Perhaps we can collapse this into the previous line so we'll have )) {
mikeproeng37
suggested changes
Nov 26, 2018
src/Optimizely/Optimizely.php
Outdated
| self::USER_ID => $userId | ||
| ] | ||
| ) | ||
| ) { |
mikeproeng37
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary