Skip to content

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Dec 18, 2018

Summary

This adds support for new audience match type conditions to the condition evaluator:

  • exact, exists, gt, lt, and substring conditions
  • Abort and return null when appropriate in leaf evaluators
  • Null handling in and/or/not evaluators
  • Assume implicit "or" when operator is missing

Test Plan

Added new unit tests.
Ran compatibility suite tests for typed audiences

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor feedback.

@oakbani oakbani merged commit b9b3ba4 into oakbani/audience-match-types Dec 24, 2018
@oakbani oakbani deleted the oakbani/audience-match-condition-evaluator-2 branch December 24, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants