Skip to content

refac(ci): switch stage order #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2018
Merged

refac(ci): switch stage order #148

merged 2 commits into from
Dec 27, 2018

Conversation

@juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Dec 21, 2018

Summary

  • switch the order of stages so that integration tests occur ahead of unit tests. this allows resetting the build status to pending without having to wait for unit tests to finish first.

@juancarlostong juancarlostong force-pushed the jctong/switch_stage_order branch from a67acf7 to a0e48c6 Compare December 21, 2018 00:25
mikeproeng37
mikeproeng37 approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 62d81a4 into master Dec 27, 2018
@aliabbasrizvi aliabbasrizvi deleted the jctong/switch_stage_order branch January 17, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juancarlostong @mikeproeng37