Skip to content

Modify Default Logger #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2018
Merged

Modify Default Logger #93

merged 2 commits into from
Feb 20, 2018

Conversation

@wangjoshuah
Copy link
Contributor

@wangjoshuah wangjoshuah commented Feb 20, 2018

Log to STDOUT by default.
Output stream is configurable.

wangjoshuah and others added 2 commits February 14, 2018 14:35
@wangjoshuah
log to stdout instead of output. Output returns logs as part of the H…
3f91494 
…TTP request
@oakbani @wangjoshuah
Default Logger Unit Tests (#90)
5231878 
* 🖊️ Fixed unit tests, edited Default Logger.
* 🖊️ Update years
mikeproeng37
mikeproeng37 approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@coveralls
Copy link

coveralls commented Feb 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.897% when pulling 5231878 on josh.wang/fix_default_logger into eca6b6c on master.

@wangjoshuah wangjoshuah merged commit 9a3072b into master Feb 20, 2018
@wangjoshuah wangjoshuah deleted the josh.wang/fix_default_logger branch February 20, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

@oakbani oakbani Awaiting requested review from oakbani

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangjoshuah @coveralls @mikeproeng37 @oakbani