Skip to content

Conversation

@ab-cs13
Copy link

@ab-cs13 ab-cs13 commented Sep 17, 2025

forked synced with upstream. odb-peering is added.

asungur and others added 30 commits July 15, 2025 21:16
Revert "add rotation test to repliace the error"

This reverts commit 392c135fcea75b3f991a851cd8c4a0395f55a0e9.

Reapply "add rotation test to repliace the error"

This reverts commit c9d3032179cd48d3bc880e2e0e47e4c9a1dc153a.
Over time the `_update` case has become bloated with multiple distinct test scenarios. This change splits this test into multiple distinct tests so they can be parallelized more efficiently.

```console
% make testacc PKG=elasticache TESTS=TestAccElastiCacheUserGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_ec_user_group-skip-removed-user 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUserGroup_'  -timeout 360m -vet=off
2025/09/16 14:38:28 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/16 14:38:28 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccElastiCacheUserGroup_disappears (140.26s)
--- PASS: TestAccElastiCacheUserGroup_tags (140.39s)
--- PASS: TestAccElastiCacheUserGroup_basic (143.97s)
--- PASS: TestAccElastiCacheUserGroup_engineValkey (200.12s)
--- PASS: TestAccElastiCacheUserGroup_update (262.93s)
--- PASS: TestAccElastiCacheUserGroup_rotate (453.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        459.658s
```
ab-cs13 and others added 27 commits September 17, 2025 11:22
…kip-removed-user

aws_elasticache_user_group: Skip deleted users during user group update
Bumps [github.com/hashicorp/terraform-json](https://github.com/hashicorp/terraform-json) from 0.26.0 to 0.27.1.
- [Release notes](https://github.com/hashicorp/terraform-json/releases)
- [Commits](hashicorp/terraform-json@v0.26.0...v0.27.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-json
  dependency-version: 0.27.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pdates (hashicorp#44319)

* build(deps): bump the aws-sdk-go-v2 group across 1 directory with 8 updates

Bumps the aws-sdk-go-v2 group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2/service/amp](https://github.com/aws/aws-sdk-go-v2) | `1.40.0` | `1.40.1` |
| [github.com/aws/aws-sdk-go-v2/service/budgets](https://github.com/aws/aws-sdk-go-v2) | `1.37.5` | `1.38.0` |
| [github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs](https://github.com/aws/aws-sdk-go-v2) | `1.57.4` | `1.58.0` |
| [github.com/aws/aws-sdk-go-v2/service/costexplorer](https://github.com/aws/aws-sdk-go-v2) | `1.55.5` | `1.56.0` |
| [github.com/aws/aws-sdk-go-v2/service/osis](https://github.com/aws/aws-sdk-go-v2) | `1.19.3` | `1.20.0` |
| [github.com/aws/aws-sdk-go-v2/service/outposts](https://github.com/aws/aws-sdk-go-v2) | `1.56.4` | `1.56.5` |
| [github.com/aws/aws-sdk-go-v2/service/s3control](https://github.com/aws/aws-sdk-go-v2) | `1.65.6` | `1.66.0` |
| [github.com/aws/aws-sdk-go-v2/service/transfer](https://github.com/aws/aws-sdk-go-v2) | `1.65.4` | `1.65.5` |



Updates `github.com/aws/aws-sdk-go-v2/service/amp` from 1.40.0 to 1.40.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.40.0...service/s3/v1.40.1)

Updates `github.com/aws/aws-sdk-go-v2/service/budgets` from 1.37.5 to 1.38.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ssm/v1.37.5...v1.38.0)

Updates `github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs` from 1.57.4 to 1.58.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.57.4...service/s3/v1.58.0)

Updates `github.com/aws/aws-sdk-go-v2/service/costexplorer` from 1.55.5 to 1.56.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/iot/v1.55.5...service/s3/v1.56.0)

Updates `github.com/aws/aws-sdk-go-v2/service/osis` from 1.19.3 to 1.20.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.20.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/mq/v1.19.3...v1.20.0)

Updates `github.com/aws/aws-sdk-go-v2/service/outposts` from 1.56.4 to 1.56.5
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/eks/v1.56.4...service/eks/v1.56.5)

Updates `github.com/aws/aws-sdk-go-v2/service/s3control` from 1.65.6 to 1.66.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3control/v1.65.6...service/s3/v1.66.0)

Updates `github.com/aws/aws-sdk-go-v2/service/transfer` from 1.65.4 to 1.65.5
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/transfer/v1.65.4...service/transfer/v1.65.5)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/amp
  dependency-version: 1.40.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/budgets
  dependency-version: 1.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs
  dependency-version: 1.58.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/costexplorer
  dependency-version: 1.56.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/osis
  dependency-version: 1.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/outposts
  dependency-version: 1.56.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3control
  dependency-version: 1.66.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/transfer
  dependency-version: 1.65.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk-go-v2
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: make clean-tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jared Baker <jared.baker@hashicorp.com>
hashicorp#44278)

* update to make changes in diff files

* rename the block & update anchor
@github-actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ab-cs13 ab-cs13 merged commit aeaede5 into main Sep 17, 2025
16 of 20 checks passed
@github-actions
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants