Skip to content

Conversation

@richardpiantini
Copy link
Contributor

@richardpiantini richardpiantini commented Sep 9, 2025

WMS ID # 2000

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

  • All filenames are lower case (including folders, images, files, etc.)
  • Filenames are descriptive
  • Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
  • Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
  • Image references in markdown contain an alternate text

Copy link
Contributor

@ramonamagadan18 ramonamagadan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richardpiantini ! Checking your PR, I found some images with private information that required your attention:

2 images have your name visible :

  • identity-access-management/iam/images/Users-Groups-AddUser.png
  • identity-access-management/iam/images/id-domains-create-user.png

1 image has visible compartment:

  • identity-access-management/iam/images/id-domains-default.png

1 image has visible ocid:

  • identity-access-management/iam/images/id-domains-group-detail.png

Along with that, all filenames should be in lowwercase. The following image needs to be renamed:

  • identity-access-management/iam/images/Users-Groups-AddUser.png

Also, i noticed that you have changes in 4 folders, have you updated 4 workshops?
Let me know when you hide the private information from above. Thank you!

@richardpiantini
Copy link
Contributor Author

richardpiantini commented Sep 10, 2025

Thank you Ramona, I've updated the changes and yes I updated 4 labs inside of the intro to oci workshop. Not different workshops.

@ramonamagadan18 ramonamagadan18 merged commit e3d46b4 into oracle-livelabs:main Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants