Skip to content

Conversation

VipulMascarenhas
Copy link
Contributor

This PR adds documentation along with examples on how users can access Aqua resources via ads CLI.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 27, 2024

### Description

Creates a new evaluation model using an existing Aqua model or model deployment. Currently, evaluation is only supported via model deployment as the source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove any mention of the supporting evaluating offline models. Currently we only support deployed models.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to Creates a new evaluation model using an existing Aqua model deployment.


`--evaluation_source_id [str]`

The evaluation source id. Must be either model or model deployment ocid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only model deployment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.


`--dataset_path [str]`

The dataset path for the evaluation. Could be either a local path from notebook session or an object storage path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not mention the local path maybe at all in the CLI?


The description of the evaluation. Defaults to None.

`--memory_in_gbs [float]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the flexible shapes. Despite we only support flexible shapes for now, in future we will return the other shapes as well.


### Example

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also added supporting the rouge metric.

--metrics '[{"name": "bertscore", "args": {}}, {"name": "rouge", "args": {}}]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

"frequency_penalty": 0,
"stop": [],
"shape": "VM.Standard.E3.Flex",
"dataset_path": "oci://aqua-eval-test-bucket@namespace/dataset/evaluation-sample-with-sys-message.jsonl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the real path should be removed?

Copy link
Contributor Author

@VipulMascarenhas VipulMascarenhas Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is a made-up path as well, but I'll update it to oci://<bucket>@<namespace>/path/to/the/dataset.jsonl


`--report_path [str]`

The report path for the evaluation. Must be an object storage path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add supported values for every lag just below the description?

--report_path [str]

The evaluation's dataset path, which must be an Object Storage path.
Example: oci://<bucket>@<namespace>/path/to/the/dataset.jsonl

Copy link
Contributor Author

@VipulMascarenhas VipulMascarenhas Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, I'll some details in the description section for each param. Maybe not for all params that are easily understood or used across oci, but the ones we've introduced.

@darenr darenr merged commit 376b3f5 into oracle-samples:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants