Skip to content

Conversation

@martin-bach-oracle
Copy link
Contributor

In this pull request I'd like you to review the content I created for ease of access. All examples have been tested on 23.2.0 (Oracle Database 23c Free-Developer Release) and should work without issues.

@martin-bach-oracle martin-bach-oracle requested a review from gvenzl May 23, 2023 06:28
echo "🛠️ Building site"
echo "Please wait..."
antora local-playbook.yml
npx antora local-playbook.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original generate.sh script assumed a global antora installation. In my opinion the call should be changed to use npx antora ... to allow for a local installation.

Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
@gvenzl gvenzl merged commit 30362d9 into main May 23, 2023
@gvenzl gvenzl deleted the javascript branch May 23, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants