Aqua v1.0.1 release #803
Aqua v1.0.1 release #803
Conversation
…finetune. - added tracking shapes for evaluation
…finetune. - added finetune shape, finetune model and combination of a shape and model
|
📌 Cov diff with main: 📌 Overall coverage: |
|
|
||
| def __init__( | ||
| self, | ||
| log_level: str = os.environ.get(ENV_VAR_LOG_LEVEL, "ERROR").upper(), |
There was a problem hiding this comment.
What if user pass empty string as a log_level?
There was a problem hiding this comment.
ads aqua model list --log-level=""
just checked, it fails with the message:
File "/Users/<user>/miniconda3/envs/ads-local-v38/lib/python3.8/logging/__init__.py", line 198, in _checkLevel
raise ValueError("Unknown level: %r" % level)
ValueError: Unknown level: ''
@mingkang111 can we have an input check to fix this?
There was a problem hiding this comment.
It just one line check, can you add from you side instead of creating another PR and waiting for review? Thanks!
Something like:
if not log_level in [...]:
exit()
There was a problem hiding this comment.
yep, I'll update it my PR, might be better to default to Error level instead of exit. thanks Ming!
There was a problem hiding this comment.
From my understanding, ads aqua --help provides what value can be put there. If user provide wrong value, it is should be ok to fail. And the error raised here also indicate the cause for the failure, i.e. the value provided is invalid.
There was a problem hiding this comment.
That is true, but in this case the error should be human friendly. I'm ok with any solution that would make it more clear for end user.
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
Description
This PR releases v1.0.1 iteration of Aqua, mainly comprising of bug fixes and improving unit tests and covers the following:
ADS version will be updated to v2.11.8.
Jira
ODSC-55689